Please hold on this patch. It seems there is some corner case failed because of this patch. Regards, Libin >-----Original Message----- >From: Pierre-Louis Bossart [mailto:pierre-louis.bossart@xxxxxxxxxxxxxxx] >Sent: Thursday, May 23, 2019 12:22 AM >To: alsa-devel@xxxxxxxxxxxxxxxx >Cc: tiwai@xxxxxxx; broonie@xxxxxxxxxx; Yang, Libin <libin.yang@xxxxxxxxx>; >Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx> >Subject: [PATCH v2 12/12] ASoC: SOF: Intel: hda-codec: fix memory allocation > >From: Libin Yang <libin.yang@xxxxxxxxx> > >Align all users of the hdac library to use devm_kzalloc. > >Note for backports/stable: the patch ("ALSA: hdac: fix memory release for SST >and SOF drivers") needs to be applied as well. > >Fixes: 5507b8103e26 ("ASoC: SOF: Intel: Add support for HDAudio codecs") >Reviewed-by: Takashi Iwai <tiwai@xxxxxxx> >Signed-off-by: Libin Yang <libin.yang@xxxxxxxxx> >Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx> >--- > sound/soc/sof/intel/hda-codec.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > >diff --git a/sound/soc/sof/intel/hda-codec.c b/sound/soc/sof/intel/hda- >codec.c index b8b37f082309..0d8437b080bf 100644 >--- a/sound/soc/sof/intel/hda-codec.c >+++ b/sound/soc/sof/intel/hda-codec.c >@@ -62,8 +62,7 @@ static int hda_codec_probe(struct snd_sof_dev *sdev, >int address) > address, resp); > > #if IS_ENABLED(CONFIG_SND_SOC_SOF_HDA_AUDIO_CODEC) >- /* snd_hdac_ext_bus_device_exit will use kfree to free hdev */ >- hda_priv = kzalloc(sizeof(*hda_priv), GFP_KERNEL); >+ hda_priv = devm_kzalloc(sdev->dev, sizeof(*hda_priv), GFP_KERNEL); > if (!hda_priv) > return -ENOMEM; > >@@ -82,8 +81,7 @@ static int hda_codec_probe(struct snd_sof_dev *sdev, >int address) > > return 0; > #else >- /* snd_hdac_ext_bus_device_exit will use kfree to free hdev */ >- hdev = kzalloc(sizeof(*hdev), GFP_KERNEL); >+ hdev = devm_kzalloc(sdev->dev, sizeof(*hdev), GFP_KERNEL); > if (!hdev) > return -ENOMEM; > >-- >2.20.1 _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
