Re: [PATCH 2/2] ASoC: SOF: core: fix undefined nocodec reference

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 5/8/19 1:27 AM, Mark Brown wrote:
On Tue, May 07, 2019 at 11:32:36AM -0500, Pierre-Louis Bossart wrote:
The existing code mistakenly uses IS_ENABLED in C code instead of as
in conditional compilation, leading to the following error:

ld: sound/soc/sof/core.o: in function `sof_machine_check':
sound/soc/sof/core.c:279: undefined reference to `sof_nocodec_setup'

There's nothing wrong with using IS_ENABLED() in C code - it can be
cleaner than using an ifdef to help the compiler eliminate unneeded
code.

Agree, and we do make use of it. In this case it wasn't smart though.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux