On Tue, May 7, 2019 at 1:26 PM Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx> wrote: > > > > > On 5/6/19 5:53 PM, Evan Green wrote: > >>> Add support for Intel Comet Lake platforms by adding a new Kconfig for > >>> CometLake and the appropriate PCI ID. > > > >> This is odd. I checked internally a few weeks back and the CML PCI ID was 9dc8, same as WHL and CNL, so we did not add a PCI ID on purpose. To the best of my knowledge SOF probes fine on CML and the known issues can be found on the SOF github [1]. > > > > The PCI ID change is seen on later production Si versions. The PCI ID is 02c8. > > As I suspected, we are talking about different skews and generations of > the chipset and a board-level change, not silicon change. > > The CNL PCH-LP PCI ID is 0x9DC8, the CNL PCH-H PCI ID is 0xA348 (used > for CoffeeLake). Both are supported by SOF. > > What we are missing are the PCI IDs for CML PCH-LP (0x02C8) and CML > PCH-H (0x06C8). > > Can we respin this patchset to add support for those last two instead of > just the -LP case? Sure. So just to clarify, you want the entry for 0x02c8, and you want an additional entry for 0x06c8 under the same config. Will do. > > I'll send a patch to add those IDs for the HDaudio legacy driver for > consistency. Actually I've got that change ready to go too, I'm happy to send that out. > > Thanks! > -Pierre _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
