Hi Takashi, I had sent other patch before. Could it can apply? > -----Original Message----- > From: Takashi Iwai <tiwai@xxxxxxx> > Sent: Tuesday, May 7, 2019 4:40 PM > To: Kailang <kailang@xxxxxxxxxxx> > Cc: (alsa-devel@xxxxxxxxxxxxxxxx) <alsa-devel@xxxxxxxxxxxxxxxx> > Subject: Re: Support low power consumption for ALC3254 > > On Tue, 07 May 2019 09:53:24 +0200, > Kailang wrote: > > > > Hi Takashi, > > > > Chrome OS want to support low power consumption. > > This patch will support low consumption. > > Looks mostly OK, but one question: why hp_pin isn't set? If hp_pin not assigned, depop procedure must run. So, if system doesn't have HP. It must assigned default 0x21 pin to run depop procedure. > That is, if the fixup sets up pin 0x21 as HP, the change about hp_pin can be > avoided, no? Yes, it hp_pin = 0x21. It doesn't change hp_pin. > > > thanks, > > Takashi > > ------Please consider the environment before printing this e-mail. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel