The use of PB51ED in the enum variant does not make complete sense. The System76 oryp5 is based on the P960ED and P960EF models, not the PB51ED. I am about to add two more models that require similar fixups - NH58RCQ and NH70RCQ. This patch basically applies to any current Clevo motherboards with an ALC1220 and a headphone combo jack. Perhaps something like ALC1220_FIXUP_CLEVO_HP_COMBO would be a better name? -- Jeremy Soller System76 Engineering Manager jeremy@xxxxxxxxxxxx On Wed, Apr 3, 2019, at 3:57 AM, Takashi Iwai wrote: > On Tue, 02 Apr 2019 15:52:04 +0200, > Richard Sailer wrote: > > > > This adds a SND_PCI_QUIRK(...) line for the Tuxedo XC 1509. > > > > The Tuxedo XC 1509 and the System76 oryp5 are the same barebone > > notebooks manufactured by Clevo. To name the fixups both use after the > > actual underlying hardware, this patch also changes System76_orpy5 > > to clevo_pb51ed in 2 enum symbols and one function name, > > matching the other pci_quirk entries which are also named after the device ODM. > > > > Signed-off-by: Richard Sailer <rs@xxxxxxxxxxxxxxxxxxx> > > Applied, thanks. > > > Takashi > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@xxxxxxxxxxxxxxxx > https://mailman.alsa-project.org/mailman/listinfo/alsa-devel > _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
