Re: [ALSA patch] [PATCH 5/5] pcm: Update pcm->avail_min with needed_slave_avail_min, after reading unaligned frames

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 30 Apr 2019 09:38:43 +0200,
<vanitha.channaiah@xxxxxxxxxxxx> wrote:
> 
> From: Vanitha Channaiah <vanitha.channaiah@xxxxxxxxxxxx>
> 
> Issue: After partial read of unaligned frames, snd_pcm_wait()
> would block for the pcm->avail_min which would result in
> blocking of snd_pcm_wait() for longer periods i.e more than
> one period as specified by avail_min
> 
> Fix: After reading unaligned frames, set the pcm->avail_min
> to the needed available frames so that snd_pcm_wait() blocks till
> needed available frames.
> Once needed available frames are read, set back the original
> pcm->avail_min
> 
> Signed-off-by: Vanitha Channaiah <vanitha.channaiah@xxxxxxxxxxxx>

This kind of changes in the core code should be avoided as much as
possible, especially if it's only relevant with the specific plugins.

Sorry, this isn't convincing enough.  If this is a MUST, please
clarify better.


thanks,

Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux