On 5/2/19 10:19 AM, Greg KH wrote:
On Thu, May 02, 2019 at 04:29:16PM +0530, Vinod Koul wrote:
After applying cleanup from Pierre, I realized few more things can be
cleaned up as well, so fixing these instance in the subsystem.
Looks like bool is no longer encouraged, but I have skipped those and few
alignment as they caused code to look worse.
Greg,
if you are okay I would like to add this as well (i know it is late, but
they are cosmetic changes and no logic ones, let me know and I can
send a updated PR)
This made no sense, as it was on top of Pierre's patches.
I've applied both his, and your, patch series to the tree now, hopefully
this type of mess doesn't happen again in the future.
Please be a lot more specific as to what you expect me to do with a
patch series, and what exactly it is for/against/after, as this was not
obvious at all.
ugh, someone owes me a drink...
greg k-h
I'll be glad to buy a round at the next ELC.
I also boiled initially when I saw the Kconfig patch until I realized it
was a different patch. Same for the SPDX files. It wasn't obvious from a
quick review and I could have been the one sending a nasty email.
There are additional cleanups from Vinod that I saw but didn't fix as I
wasn't sure they made the code readable (e.g. dev_dbg logs exceeding 80
chars and newlines after loops), but I also missed others that are very
much needed, so please add my Rvb tag for this 'more code cleanups' series.
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
Thank you Vinod for the additional work. I am almost done with the
sysfs/debugfs cleanups and should post that next week.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
