Re: [PATCH v5 00/21] ASoC: Sound Open Firmware (SOF) - Intel support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 12 Apr 2019 18:08:43 +0200,
Pierre-Louis Bossart wrote:
> 
> This patch series introduces the support for Intel devices (Baytrail,
> CherryTrail, Broadwell, ApolloLake, GeminiLake, CannonLake,
> IceLake). Support for Haswell, Skylake and KabyLake is incomplete at
> the moment and is not shared for now.
> 
> The series starts with the 'legacy' devices, then all the more recent
> ones and concludes with ACPI/PCI hooks. SKL+ platforms can be compiled
> without HDaudio link/codec support, in which case the hdac library is
> not used. When support for HDMI or HDaudio codecs is selected, parts
> of this library are used.
> 
> A small set of machine drivers supported by SOF is now provided as
> part of this series, more to follow.
> 
> Support for SPI-based devices, compressed streams is also not provided
> for now since it's not ready for upstream just yet.
> 
> Thank you for reviews and comments, we appreciate the time spent
> commenting on this large patchset. Thanks in particular to Alan Cox
> and Andy Shevchenko for their comments on an earlier version.
> 
> Changes since v4:
> 
> Feedback from Andy:
> Rename EDISON as MERRIFIELD, byt_pci_probe as tng_pci_probe
> 
> Feedback from Takashi:
> Remove superfluous initializations and casts
> Tabify Kconfigs
> Fix dependency on SND_DMA_SGBUFF
> 
> Other updates:
> Major IPC rework (Intel-specific parts moved out of the core)
> Fix NOCODEC/HDA compatibility
> Fix period bytes calculation
> Fix CTX_SAVE handling (do not read mailbox which can be powered off)
> Fix ROM message handling
> Drop unexpected IPC replies
> Add prepare for BE dailink
> Fix typos in comments
> 
> Changes since v3:
> 
> Removed Haswell, Skylake and Kabylake support (code is not tested or
> is still under development). These devices will be re-added when there
> is functional firmware and for Skylake/Kabylake a signed version of
> the firmware usable on existing platforms.
> Added support for existing machine drivers when relevant (more machine
> drivers will be added in next batch)
> Fixed hardware programming sequences (ROM init timeout, HDaudio
> capture, simultaneous capture and playback, DMA preload)
> Avoid reading IPC reply on CTX_SAVE reply since memory windows might
> be powered off.
> Simplified NOCODEC support, now mutually exclusive with HDaudio link
> to avoid suspend/resume issues.
> 
> Changes since v2:
> 
> Addressed dozens of comments from Takashi Iwai, Mark Brown, Andy
> Shevchenko, Daniel Baluta (Thanks!)
> Transition to new display power management
> Fixed suspend issues
> Optimized register polling, better handling of timeouts and firmware
> download retries
> Detect number of HDaudio codec and select machine driver accordingly
> Added workqueue based probe for HDaudio (dependency on modules)
> Fixed platform name override and conflicts with DT deferred probe
> changes
> Added prefix for firmware and topology files and module arguments
> Split Baytrail and Edison
> Fixed warnings (smatch, cppcheck)

For the whole series,
  Reviewed-by: Takashi Iwai <tiwai@xxxxxxx>


thanks,

Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux