Hi Yue, Looks good to me. Just one question for Cosmin: On Wed, Apr 17, 2019 at 6:10 PM Yue Haibing <yuehaibing@xxxxxxxxxx> wrote: > > From: YueHaibing <yuehaibing@xxxxxxxxxx> > > Fixes gcc '-Wunused-but-set-variable' warning: > > sound/soc/fsl/fsl_micfil.c: In function 'get_clk_div': > sound/soc/fsl/fsl_micfil.c:154:6: warning: variable 'osr' set but not used [-Wunused-but-set-variable] > > It is never used since introduction in > commit 47a70e6fc9a8 ("ASoC: Add MICFIL SoC Digital Audio Interface driver.") > > Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx> > --- > sound/soc/fsl/fsl_micfil.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/sound/soc/fsl/fsl_micfil.c b/sound/soc/fsl/fsl_micfil.c > index 40c07e7..f7f2d29 100644 > --- a/sound/soc/fsl/fsl_micfil.c > +++ b/sound/soc/fsl/fsl_micfil.c > @@ -151,12 +151,9 @@ static inline int get_clk_div(struct fsl_micfil *micfil, > { > u32 ctrl2_reg; > long mclk_rate; > - int osr; > int clk_div; > > regmap_read(micfil->regmap, REG_MICFIL_CTRL2, &ctrl2_reg); I noticed now that we also read ctrl2_reg without using it. Is this as intended? > - osr = 16 - ((ctrl2_reg & MICFIL_CTRL2_CICOSR_MASK) > - >> MICFIL_CTRL2_CICOSR_SHIFT); > > mclk_rate = clk_get_rate(micfil->mclk); > > -- > 2.7.4 > > _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel