Hi Pierre, >-----Original Message----- >From: Pierre-Louis Bossart [mailto:pierre-louis.bossart@xxxxxxxxxxxxxxx] >Sent: Friday, April 12, 2019 9:52 PM >To: Yang, Libin <libin.yang@xxxxxxxxx>; alsa-devel@xxxxxxxxxxxxxxxx; >tiwai@xxxxxxx; broonie@xxxxxxxxxx >Subject: Re: [PATCH] ASoC: codec: hdac_hdmi add device_link to >card device > > >>>> + device_link_add(component->card->dev, &hdev->dev, >>> DL_FLAG_RPM_ACTIVE | >>>> + DL_FLAG_AUTOREMOVE_CONSUMER); >>> >>> Should device_link_free() be added to hdmi_codec_remove then? >> >> As Takashi suggested, I add the DL_FLAG_AUTOREMOVE_CONSUMER flag. >> This will make sure the link will be freed when machine driver are removed. >> And as machine driver depends on the hdac_hdmi module, when >> hdmi_codec_remove() is called, the link is freed already. > >ok, maybe adding a comment would help dummies like me who didn't know >about this flag? Thanks! Thanks for suggestion. I will add the comment. Regards, Libin _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
