On Thu, 11 Apr 2019 11:34:47 +0200, libin.yang@xxxxxxxxx wrote: > > From: Libin Yang <libin.yang@xxxxxxxxx> > > This patchset add the device_link between the machine devices > of intel boards and HDMI audio codec. This can make sure that > display audio power domain is always turned on before operating > on the HDMI audio codecs. > > patch 2 adds the helper functions in a new created header file. > However skl_hda_dsp_generic doesn't use these helper functions > because skl_hda_dsp_generic is a special driver, the add link > and delete link operations are in different source code files. > If it includes the header file, there is compiling warning. Now I took a look at the core implementation, and wonder whether we may drop the device_link_del() call if we create the link with DL_FLAG_AUTOREMOVE_CONSUMER? If that works, you don't have to track the link pointer, so it can be dropped as well; i.e. the only addition would be just the extra call of device_link_add() for each machine driver. thanks, Takashi > > Libin Yang (12): > ASoC: intel: skl_hda_dsp_generic: add device_link to HDMI audio > ASoC: intel: boards: define some general functions for hdac_hdmi > ASoC: intel: bxt_da7219_max98357a: add device_link to HDMI audio > ASoC: intel: bxt_rt298: add device_link to HDMI audio > ASoC: intel: glk_rt5682_max98357a: add device_link to HDMI audio > ASoC: intel: kbl_da7219_max98357a: add device_link to HDMI audio > ASoC: intel: kbl_da7219_max98927: add device_link to HDMI audio > ASoC: intel: kbl_rt5660: add device_link to HDMI audio > ASoC: intel: kbl_rt5663_max98927 add device_link to HDMI audio > ASoC: intel: kbl_rt5663_rt5514_max98927 add device_link to HDMI audio > ASoC: intel: skl_nau88l25_max98357a add device_link to HDMI audio > ASoC: intel: skl_nau88l25_ssm4567 add device_link to HDMI audio > > sound/soc/intel/boards/bxt_da7219_max98357a.c | 14 +++++++ > sound/soc/intel/boards/bxt_rt298.c | 14 ++++++- > sound/soc/intel/boards/glk_rt5682_max98357a.c | 14 +++++++ > sound/soc/intel/boards/hdac_hdmi_common.h | 46 ++++++++++++++++++++++ > sound/soc/intel/boards/kbl_da7219_max98357a.c | 14 +++++++ > sound/soc/intel/boards/kbl_da7219_max98927.c | 14 +++++++ > sound/soc/intel/boards/kbl_rt5660.c | 14 ++++++- > sound/soc/intel/boards/kbl_rt5663_max98927.c | 14 ++++++- > .../soc/intel/boards/kbl_rt5663_rt5514_max98927.c | 14 ++++++- > sound/soc/intel/boards/skl_hda_dsp_common.c | 22 +++++++++++ > sound/soc/intel/boards/skl_hda_dsp_common.h | 1 + > sound/soc/intel/boards/skl_hda_dsp_generic.c | 12 ++++++ > sound/soc/intel/boards/skl_nau88l25_max98357a.c | 36 ++++++++++++++++- > sound/soc/intel/boards/skl_nau88l25_ssm4567.c | 36 ++++++++++++++++- > 14 files changed, 259 insertions(+), 6 deletions(-) > create mode 100644 sound/soc/intel/boards/hdac_hdmi_common.h > > -- > 2.7.4 > _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
