There is a good reason to use -1 for quirk-override not set. The user may want to override the quirk variable to actual 0, on CHT we default to: /* Others default to internal-mic-in1-map, mono-speaker */ quirk = BYT_CHT_ES8316_INTMIC_IN1_MAP | BYT_CHT_ES8316_MONO_SPEAKER; Which is 0x20000, if the user now justs wants to clear the BYT_CHT_ES8316_MONO_SPEAKER flag through the override, then the user must be able to specify 0 as override.
ok, I accept the argument but then why don't we do the same in other machine drivers? I could make the same argument for bytcr_rt5640/51, so we should align all machine drivers using this mechanism.
_______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
