Re: [RFC PATCH 1/3] ASoC: core: do not unload topology in unregister_component()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 04, 2019 at 05:30:38PM -0700, Ranjani Sridharan wrote:
> Typically, topology is loaded when the card is registered
> by the machine driver and the link components are probed.
> Therefore, it should be unloaded when the link components
> are removed. This will make the register/unregister component
> methods balanced.

>  			continue;
>  
> -		snd_soc_tplg_component_remove(component,
> -					      SND_SOC_TPLG_INDEX_ALL);
>  		snd_soc_component_del_unlocked(component);
>  		found = 1;

Isn't this a robustness fix?  It's just freeing anything that's left
over, it doesn't free specific stuff and shouldn't stop anything else
freeing that before so if we made a mistake earlier on it'll clean up
after you.

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux