Re: [PATCH 1/3] soundwire: fix style issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks for the review Joe,

@@ -458,13 +458,13 @@ static int sdw_assign_device_num(struct sdw_slave *slave)

  		mutex_unlock(&slave->bus->bus_lock);
  		if (dev_num < 0) {
  			dev_err(slave->bus->dev, "Get dev_num failed: %d",
-								dev_num);
+				dev_num);
You could also add the missing terminating '\n' to these formats like:

  			dev_err(slave->bus->dev, "Get dev_num failed: %d\n",

Yes indeed, I just fixed that tools reported, but that is a miss. Will fix with a v2 (hopefully with other comments).

-Pierre

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux