Re: [PATCH -next] ASoC: simple-card-utils: remove set but not used variable ''

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 3/23/2019 7:38 AM, YueHaibing wrote:
Fixes gcc '-Wunused-but-set-variable' warning:

sound/soc/generic/simple-card-utils.c: In function 'asoc_simple_parse_clk':
sound/soc/generic/simple-card-utils.c:164:18: warning:
  parameter 'dai_name' set but not used [-Wunused-but-set-parameter]

It's not used since commit 0580dde59438 ("ASoC: simple-card-utils: add


I am not able to find this commit

0580dde59438


asoc_simple_debug_info()"), so can be removed.

Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
---
  sound/soc/generic/simple-card-utils.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/sound/soc/generic/simple-card-utils.c b/sound/soc/generic/simple-card-utils.c
index 4ed68348f939..db1458a19985 100644
--- a/sound/soc/generic/simple-card-utils.c
+++ b/sound/soc/generic/simple-card-utils.c
@@ -173,10 +173,8 @@ int asoc_simple_parse_clk(struct device *dev,
  	 * see
  	 *	soc-core.c :: snd_soc_init_multicodec()
  	 */
-	if (dlc) {
+	if (dlc)
  		dai_of_node	= dlc->of_node;
-		dai_name	= dlc->dai_name;

I don't see any function like `asoc_simple_parse_clk`

but instead this `asoc_simple_card_parse_clk` and there the variable is used.

Can you double check latest code base ?

Thanks,
Mukesh


-	}
/*
  	 * Parse dai->sysclk come from "clocks = <&xxx>"





_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux