On Thu, 14 Mar 2019 08:43:52 +0100, Jaroslav Kysela wrote: > > Dne 13. 03. 19 v 11:50 Takashi Iwai napsal(a): > > On Thu, 07 Mar 2019 20:49:22 +0100, > > Jaroslav Kysela wrote: > >> > >> Dne 07. 03. 19 v 9:11 Kailang napsal(a): > >>> Hi Jaroslav, > >>> > >>> I need to check with Intel chrome audio team for the name change. > >>> But chrome OS used 'alc-sense-combo' for early patch file. > >> > >> But with your patch, the ALC225_FIXUP_HEADSET_JACK and > >> ALC295_FIXUP_CHROME_BOOK do a different thing, so it's not a simple > >> replacement. Your chrome book fixup is not universal, so it should be > >> distinguished in my opinion. > > > > Yeah, ideally this should be implemented in another model name. > > > > But, in this particular case, the original quirk was provided > > specifically for Chromebook (despite of its generic model name > > "alc-sense-combo"), and since Chromebook is already using this string, > > it's better to keep the string as before. That is, the risk of > > breakage for other users of this model name is much lower than the > > burden of changes of the fixed string for Chrome, I suppose.\ > > > > So I'm going to take the patch as is -- as an exception. > > It would be better to move the new code to > alc_fixup_headset_jack() then, because ALC225_FIXUP_HEADSET_JACK is not > reused and we don't have a model name for it now. I would create new > fixup routines only when really necessary. Makes sense. Care to send a cleanup patch on the top? Thanks! Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
