On 3/13/19 11:09 AM, Jaroslav Kysela wrote:
This is just a port of the ASoC Icelake HDMI codec code to the legacy HDA driver with some cleanups. ASoC commit 019033c854a20e10f691f6cc0e897df8817d9521: "ASoC: Intel: hdac_hdmi: add Icelake support"
Thanks Jaroslav, we were just talking today about this but you beat us to it.
One comment below on the geminilake ID:
#define is_geminilake(codec) (((codec)->core.vendor_id == 0x8086280d) || \ ((codec)->core.vendor_id == 0x80862800))
+HDA_CODEC_ENTRY(0x80862800, "Geminilake HDMI", patch_i915_glk_hdmi),
This 0x2800 ID does not seem to be legit. No one at Intel, including the hardware IP owner, was able to confirm why this value was provided upstream, it is not part of any internal hardware documentation, is suspiciously out-of-sequence and is not used in the hdac_hdmi code. The contributor who released this value is no longer with Intel so I would really suggest removing this ID from the list supported by the legacy driver. I can send a patch next week for this.
_______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
