Hi Jaroslav,
I had modified the patch as you mentioned.
But I don't know how to use git send-email.
BR,
Kailang
-----Original Message-----
From: Jaroslav Kysela <perex@xxxxxxxx>
Sent: Friday, March 8, 2019 3:49 AM
To: Kailang <kailang@xxxxxxxxxxx>; Takashi Iwai (tiwai@xxxxxxx) <tiwai@xxxxxxx>
Cc: (alsa-devel@xxxxxxxxxxxxxxxx) <alsa-devel@xxxxxxxxxxxxxxxx>
Subject: Re: [alsa-devel] ChromeBook machine will lose MIC JD
Dne 07. 03. 19 v 9:11 Kailang napsal(a):
> Hi Jaroslav,
>
> I need to check with Intel chrome audio team for the name change.
> But chrome OS used 'alc-sense-combo' for early patch file.
But with your patch, the ALC225_FIXUP_HEADSET_JACK and ALC295_FIXUP_CHROME_BOOK do a different thing, so it's not a simple replacement. Your chrome book fixup is not universal, so it should be distinguished in my opinion.
Also, please, inline your patches or use ;git send-email' command to send your commit to this ML for a review.
Thanks,
Jaroslav
> It also need to add this patch.
>
> Oh! Sorry!
> I sent it with HTML mode.
> I need to resend again for TXT mode.
>
> BR,
> Kailang
>
> -----Original Message-----
> From: Jaroslav Kysela <perex@xxxxxxxx>
> Sent: Thursday, March 7, 2019 4:03 PM
> To: Kailang <kailang@xxxxxxxxxxx>; Takashi Iwai (tiwai@xxxxxxx)
> <tiwai@xxxxxxx>
> Cc: (alsa-devel@xxxxxxxxxxxxxxxx) <alsa-devel@xxxxxxxxxxxxxxxx>
> Subject: Re: [alsa-devel] ChromeBook machine will lose MIC JD
>
> Dne 07. 03. 19 v 8:56 Kailang napsal(a):
>> Hi Takashi,
>>
>> Attach patch will solve the issue for Mic JD lose.
>>
>
> - {.id = ALC225_FIXUP_HEADSET_JACK, .name = "alc-sense-combo"},
> + {.id = ALC295_FIXUP_CHROME_BOOK, .name = "alc-sense-combo"},
>
> Define another name here like 'alc-chrome-book' and don't remove the previous model name 'alc-sense-combo'.
>
> Jaroslav
>
> --
> Jaroslav Kysela <perex@xxxxxxxx>
> Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
>
> ------Please consider the environment before printing this e-mail.
>
--
Jaroslav Kysela <perex@xxxxxxxx>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
Attachment:
0002-chrome-headset-mic-jd.patch
Description: 0002-chrome-headset-mic-jd.patch
_______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
