On 28/02/2019 17:30, Russell King wrote:
> Limiting the value of the passed in params->msbits in the hw_params()
> callback is redundant on three counts:
>
> 1. We already specify in the DAI driver that we can only handle up to
> 24 bits. This means msbits will be limited to 24 via the ALSA
> constraints imposed by the ASoC core, unless we have multiple codecs
> that can handle more bits.
>
> 2. Nothing in our hw_params() implementation uses this value.
>
> 3. The copy of the params that we are passed by the ASoC core never
> reads back the msbits value.
>
> Consequently, this code is unnecessary and does nothing useful. Remove
> it.
>
> Signed-off-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxx>
Reviewed-by: Jyri Sarha <jsarha@xxxxxx>
> ---
> sound/soc/codecs/hdmi-codec.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/sound/soc/codecs/hdmi-codec.c b/sound/soc/codecs/hdmi-codec.c
> index d5f73c837281..35df73e42cbc 100644
> --- a/sound/soc/codecs/hdmi-codec.c
> +++ b/sound/soc/codecs/hdmi-codec.c
> @@ -484,9 +484,6 @@ static int hdmi_codec_hw_params(struct snd_pcm_substream *substream,
> params_width(params), params_rate(params),
> params_channels(params));
>
> - if (params_width(params) > 24)
> - params->msbits = 24;
> -
> ret = snd_pcm_create_iec958_consumer_hw_params(params, hp.iec.status,
> sizeof(hp.iec.status));
> if (ret < 0) {
>
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
