Re: [PATCH v4 07/14] ASoC: SOF: Add DSP firmware logger support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2/20/19 11:44 AM, Mark Brown wrote:
On Wed, Feb 13, 2019 at 04:07:27PM -0600, Pierre-Louis Bossart wrote:

+	/* make sure count is <= avail */
+	count = avail > count ? count : avail;
count = min(avail, count)?
as discussed in the last review, we didn't use min() since it adds a number of obscure warnings with sparse. I haven't found any time to look into this so for now left the code as is. Sparse is a useful tool for the address checks (topology/DMAs with _le32, __iomem, etc), the fewer warnings we get the better.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux