Re: [PATCH 1/3] ALSA: ac97: Fix of-node refcount unbalance

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Takashi Iwai <tiwai@xxxxxxx> writes:

> ac97_of_get_child_device() take the refcount of the node explicitly
> via of_node_get(), but this leads to an unbalance.  The
> for_each_child_of_node() loop itself takes the refcount for each
> iteration node, hence you don't need to take the extra refcount
> again.
>
> Fixes: 2225a3e6af78 ("ALSA: ac97: add codecs devicetree binding")
> Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>
> ---
>
> Only compile-tested.  Please review carefully.  Thanks!
Hi Takashi,

Reviewed-by: Robert <robert.jarzmik@xxxxxxx>

Cheers.

--
Robert
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux