That is good to know. I will resend the patch soon.
--
Jeremy Soller
System76, Inc.
Engineering Manager
jeremy@xxxxxxxxxxxx
On Wed, Jan 30, 2019, at 10:34 AM, Takashi Iwai wrote:
> On Tue, 29 Jan 2019 20:52:01 +0100,
> Jeremy Soller wrote:
> >
> > Headset microphone support for System76 darp5
>
> The changes look mostly OK, but could you give a bit more details?
>
> > @@ -6606,6 +6616,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> > SND_PCI_QUIRK(0x103c, 0x18e6, "HP", ALC269_FIXUP_HP_GPIO_LED),
> > SND_PCI_QUIRK(0x103c, 0x218b, "HP", ALC269_FIXUP_LIMIT_INT_MIC_BOOST_MUTE_LED),
> > SND_PCI_QUIRK(0x103c, 0x225f, "HP", ALC280_FIXUP_HP_GPIO2_MIC_HOTKEY),
> > + SND_PCI_QUIRK(0x1558, 0x1325, "System76", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
> > /* ALC282 */
> > SND_PCI_QUIRK(0x103c, 0x21f9, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
> > SND_PCI_QUIRK(0x103c, 0x2210, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
>
> We keep the list in the ID number order, so please put at the
> appropriate place.
>
>
> thanks,
>
> Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
