Re: [PATCH v3 01/14] ASoC: SOF: Add Sound Open Firmware driver core

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 1/29/19 10:49 AM, Daniel Baluta wrote:
<snip>

diff --git a/sound/soc/sof/core.c b/sound/soc/sof/core.c
<snip>

+
+/* SOF defaults if not provided by the platform in ms */
+
+       /* firmware loader */
+       int cl_bar;
This cl_bar variable seems to be only assigned to but never used.

I propose to remove it if there is no much trouble.

Indeed, not sure what it's supposed to be used for, it was part of the initial commit for all the files below and never used. If it's not been used in a year it's probably useless, I'll remove it.

git grep cl_bar

intel/bdw.c:    sdev->cl_bar = BDW_DSP_BAR;
intel/byt.c:    sdev->cl_bar = BYT_DSP_BAR;
intel/byt.c:    sdev->cl_bar = BYT_DSP_BAR;
intel/hsw.c:    sdev->cl_bar = HSW_DSP_BAR;
sof-priv.h:     int cl_bar;

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel




[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux