On Tue, 29 Jan 2019 15:30:54 +0100, <twischer@xxxxxxxxxxxxxx> wrote: > > > On 1/29/19 14:45, Takashi Iwai wrote: > > name is already dereferenced in strlen(), so it's too late here. > > i.e. name_size has to be evaluated after this NULL check, if any. > > Or just drop this NULL check. It's an internal function and the name > > is never NULL, practically seen. > > I have removed it. > > > name_size is the exact size of string + 1, so this is equivalent with > > strcpy(). > > I have added a comment and I am using strcpy(), now. These aren't really good cover letter :) (FWIW, the patch 0/N should be a cover letter that describes the patch set.) In anyway, I applied the latest patches now. thanks, Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel