Re: [PATCH 05/14] ALSA: pci: Remove superfluous snd_pcm_suspend*() calls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c
index 9f8d59e7e89f..ff6dbed4d3cd 100644
--- a/sound/pci/hda/hda_codec.c
+++ b/sound/pci/hda/hda_codec.c
@@ -2927,8 +2927,6 @@ static int hda_codec_runtime_suspend(struct device *dev)
  	unsigned int state;
cancel_delayed_work_sync(&codec->jackpoll_work);
-	list_for_each_entry(pcm, &codec->pcm_list_head, list)
-		snd_pcm_suspend_all(pcm->pcm);
  	state = hda_call_codec_suspend(codec);
  	if (codec->link_down_at_suspend ||
  	    (codec_has_clkstop(codec) && codec_has_epss(codec) &&

question: since we now use HDAudio codecs in an ASoC-based implementation (both with the Skylake and SOF drivers), is this creating a case where suspend no longer works? I see no suspend support in sound/soc/codec/hdac_hda.c

I just added a quick trace in the lines being deleted and those lines were definitively executed.

    list_for_each_entry(pcm, &codec->pcm_list_head, list) {
        pr_err("plb: suspending pcm\n");
        snd_pcm_suspend_all(pcm->pcm);
    }

[    2.516349] plb: suspending pcm
[    2.516350] plb: suspending pcm



_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel




[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux