>-----Original Message----- >From: Pierre-Louis Bossart [mailto:pierre-louis.bossart@xxxxxxxxxxxxxxx] >Sent: Tuesday, January 8, 2019 12:58 AM >To: Yang, Libin <libin.yang@xxxxxxxxx>; alsa-devel@xxxxxxxxxxxxxxxx; >tiwai@xxxxxxx; broonie@xxxxxxxxxx >Cc: liam.r.girdwood@xxxxxxxxxxxxxxx; Lin, Mengdong ><mengdong.lin@xxxxxxxxx> >Subject: Re: [RFC PATCH v2 1/2] ASoC: refine ASoC hdmi audio >suspend/resume > > >On 1/6/19 8:22 PM, libin.yang@xxxxxxxxx wrote: >> From: Libin Yang <libin.yang@xxxxxxxxx> >> >> hdmi_codec_prepare() will trigger hdmi runtime resume, which will set >> the bitmask of hdev->addr. And skl_suspend() will clear the bitmask of >> HDA_CODEC_IDX_CONTROLLER. HDMI codec idx is not the same as >> HDA_CODEC_IDX_CONTROLLER, which means i915 power will not be >released >> when suspend. >> >> On the other hand, hdmi_codec_prepare() don't need to call >> pm_runtime_get_sync() to wake up the audio subsystem (HDMI auido) for >> setting the codec registers. Turning display power on with >> snd_hdac_display_power() is enough. >> >> Let's use S3 without playback as an example: >> hdmi_codec_prepare() invokes the runtime resume of codec => >> snd_hdac_display_power(bus, hdev->addr, true) skl runtime resume >> skl_suspend() => >> snd_hdac_display_power(bus, HDA_CODEC_IDX_CONTROLLER, false); >> >> THis means hdev->addr will never release the display power when >> suspend. >> >> The new sequence will be: >> hdmi_codec_prepare() => >> snd_hdac_display_power(bus, hdev->addr, true) >> snd_hdac_display_power(bus, hdev->addr, false) skl runtime resume >> skl suspned > >I for one find this RFC difficult to follow. The documentation of "Power >management sequences" seems obsolete after Takashi's changes, you may >want to start with an update of the documentation which might help point out >what is broken in the sequences. I also don't see the point in trying to bypass >the runtime_pm code in codec_prepare and codec_complete. if we have the >display on/off sequence only in probe/remove and suspend/resume it makes >it easy to track states, and I wonder if it makes sense anyways to be in >suspend with the display on or vice-versa in D0 with the display off. Simple >state machines always win. Thanks for comments. I will modify the documentation of "Power Management sequences" when I submit the formal patch. The rough flow is described in my patch description. Do you think I need add more details? Actually, the HDMI driver is a little stranger. pm runtime resume of HDMI is not called even prepare() return 0. What I understand is that the runtime resume should be called. I asked a friend of mine who is familiar with kernel power management. He also can't tell why. Maybe our ALSA experts know why :). My patch is based on hdmi codec pm runtime resume not being called. The normal flow of suspend should be: Pm runtime resume => power up Pm suspend => power down. Unfortunately, our ASoC HDMI codec driver doesn't have pm suspend Callback (maybe this is why HDMI runtime resume is not called?) In original code, the hdmi prepare() will call pm_runtime_get_sync() which will trigger hdmi pm runtime resume, which will turn on display power: snd_hdac_display_power(hdev->bus, hdev->addr, true). And there is no chance to turn off the 'hdev->addr' display power before suspend, which is wrong. Regards, Libin > >> >> Signed-off-by: Libin Yang <libin.yang@xxxxxxxxx> >> --- >> sound/soc/codecs/hdac_hdmi.c | 6 ++++-- >> sound/soc/intel/skylake/skl.c | 7 ------- >> 2 files changed, 4 insertions(+), 9 deletions(-) >> >> diff --git a/sound/soc/codecs/hdac_hdmi.c >> b/sound/soc/codecs/hdac_hdmi.c index 3ab2949..782b323 100644 >> --- a/sound/soc/codecs/hdac_hdmi.c >> +++ b/sound/soc/codecs/hdac_hdmi.c >> @@ -1895,7 +1895,7 @@ static int hdmi_codec_prepare(struct device *dev) >> { >> struct hdac_device *hdev = dev_to_hdac_dev(dev); >> >> - pm_runtime_get_sync(&hdev->dev); >> + snd_hdac_display_power(hdev->bus, hdev->addr, true); >> >> /* >> * Power down afg. >> @@ -1906,6 +1906,7 @@ static int hdmi_codec_prepare(struct device *dev) >> */ >> snd_hdac_codec_read(hdev, hdev->afg, 0, > AC_VERB_SET_POWER_STATE, >> AC_PWRST_D3); >> + snd_hdac_display_power(hdev->bus, hdev->addr, false); >> >> return 0; >> } >> @@ -1915,6 +1916,7 @@ static void hdmi_codec_complete(struct device >*dev) >> struct hdac_device *hdev = dev_to_hdac_dev(dev); >> struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(hdev); >> >> + snd_hdac_display_power(hdev->bus, hdev->addr, true); >> /* Power up afg */ >> snd_hdac_codec_read(hdev, hdev->afg, 0, > AC_VERB_SET_POWER_STATE, >> AC_PWRST_D0); >> @@ -1930,7 +1932,7 @@ static void hdmi_codec_complete(struct device >*dev) >> */ >> hdac_hdmi_present_sense_all_pins(hdev, hdmi, false); >> >> - pm_runtime_put_sync(&hdev->dev); >> + snd_hdac_display_power(hdev->bus, hdev->addr, false); >> } >> #else >> #define hdmi_codec_prepare NULL >> diff --git a/sound/soc/intel/skylake/skl.c >> b/sound/soc/intel/skylake/skl.c index 60c9483..89f4d66 100644 >> --- a/sound/soc/intel/skylake/skl.c >> +++ b/sound/soc/intel/skylake/skl.c >> @@ -336,9 +336,6 @@ static int skl_suspend(struct device *dev) >> skl->skl_sst->fw_loaded = false; >> } >> >> - if (IS_ENABLED(CONFIG_SND_SOC_HDAC_HDMI)) >> - snd_hdac_display_power(bus, >HDA_CODEC_IDX_CONTROLLER, false); >> - >> return 0; >> } >> >> @@ -350,10 +347,6 @@ static int skl_resume(struct device *dev) >> struct hdac_ext_link *hlink = NULL; >> int ret; >> >> - /* Turned OFF in HDMI codec driver after codec reconfiguration */ >> - if (IS_ENABLED(CONFIG_SND_SOC_HDAC_HDMI)) >> - snd_hdac_display_power(bus, >HDA_CODEC_IDX_CONTROLLER, true); >> - >> /* >> * resume only when we are not in suspend active, otherwise need to >> * restore the device _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
