Considering with my patch this is the only remaining usage of it, do you think I should just change it into "PCM1796_DME_DISABLED" and keep this manner (so that it is consistent with rolloff_get() / PCM1796_FLT_SHARP)? Or do you insist that I should use !! anyway? On Thu, 20 Dec 2018 at 02:00, Clemens Ladisch <clemens@xxxxxxxxxx> wrote: > > tom.ty89@xxxxxxxxx wrote: > > + (data->pcm1796_regs[0][18 - PCM1796_REG_BASE] & > > + PCM1796_DME) != PCM1796_DMF_DISABLED; > > DME and DMF are different fields. Just use !!. > > With this fixed: > Acked-by: Clemens Ladisch <clemens@xxxxxxxxxx> > > > Regards, > Clemens _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
