On Thu, Dec 06, 2018 at 03:04:47PM -0600, James Schulman wrote: > Add device tree documentation for Cirrus Logic CS35L36 > speaker amplifier > > Signed-off-by: James Schulman <james.schulman@xxxxxxxxxx> > --- > +Optional properties for the "cirrus,irq-config" Sub-node > + > + - cirrus,irq-drive-select : Selects the driver type of the selected interrupt > + output. > + > + 0 = Open-drain > + 1 = Push-pull (Default) > + > + - cirrus,irq-polarity : Selects the polarity of the selected interrupt output > + when in push-pull mode. Note - when the selected interrupt output is in > + open-drain mode, INT_POL_SEL must be set to 0. > + > + 0 = Active-low (Default) > + 1 = Active-high > + Does this device tree entry in your example: interrupts = <3 IRQ_TYPE_LEVEL_LOW>; Not already convey what polarity you require? Adding a separate entry seems unnecessary. > + - cirrus,irq-gpio-select : Selects the pin to serve as the programmable > + interrupt output. > + > + 0 = PDM_DATA / SWIRE_SD / INT (Default) > + 1 = GPIO > + > + - cirrus,irq-output-enable : Enables or disables the selected interrupt output > + > + 0 = Disabled (Default) > + 1 = Enabled > + Likewise here doesn't the presence/absence of the interrupts entry convey whether you want the IRQ enabled? > + - cirrus,irq-src-select : Selects the source of the selected interrupt output. > + > + 0 = PAC-based interrupt output > + 1 = Interrupt handler (Default) > + Is there a use-case for this at the moment? This feels like it might be worth dropping until it is necessary. Thanks, Charles _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
