Re: [PATCH v3 02/14] ASoC: SOF: Add Sound Open Firmware KControl support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 11, 2018 at 04:48:37PM -0600, Pierre-Louis Bossart wrote:
> > > +	max_size = (be->max < max_size) ? be->max : max_size;
> > min() / max() ?
> 
> Good catch, this can be simplified.
> 
> Not sure I like max_size = min (be->max, max_size), it's confusing.

Hmm... It shows intention. For _max size_ you choose _minimum_ value out of two.

> 
> Maybe
> 
> if (be->max < max_size)
> 
>     max_size = be->max;

It's minor, just choose one style and use it.

-- 
With Best Regards,
Andy Shevchenko


_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel




[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux