Re: [PATCH] ALSA: usb-audio: Add vendor and product name for Dell WD19 Dock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2018/11/27 下午7:23, Takashi Iwai wrote:
On Tue, 27 Nov 2018 02:33:32 +0100,
Hui Wang wrote:
Like the Dell WD15 Dock, the WD19 Dock (0bda:402e) doens't provide
useful string for the vendor and product names too, and WD19 has a
headset Jack and a Speaker out Jack. In order to support UCM for this
Dock in the alsa-lib, here we add profile_name too.

Signed-off-by: Hui Wang <hui.wang@xxxxxxxxxxxxx>
Looking at the UCM addition, it's same as WD15 but just a different
name?  What you put "Speaker" was "Line Out" on WD15, but it was meant
to be same.  Line Out was chosen just because of convention.ted
I just checked their documents,  they are same with the output and input.

I'm OK to add a new one, but keeping "Dell-WD15-Dock" makes the new
kernel working even without UCM profile update.

OK, got it. keep the profile_name. I will send the updated patch later.


Thanks,

Hui.



thanks,

Takashi

---
  sound/usb/quirks-table.h | 10 ++++++++++
  1 file changed, 10 insertions(+)

diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h
index 849953e5775c..4c10015cc0ca 100644
--- a/sound/usb/quirks-table.h
+++ b/sound/usb/quirks-table.h
@@ -3382,5 +3382,15 @@ AU0828_DEVICE(0x2040, 0x7270, "Hauppauge", "HVR-950Q"),
  		.ifnum = QUIRK_NO_INTERFACE
  	}
  },
+/* Dell WD19 Dock */
+{
+	USB_DEVICE(0x0bda, 0x402e),
+	.driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) {
+		.vendor_name = "Dell",
+		.product_name = "WD19 Dock",
+		.profile_name = "Dell-WD19-Dock",
+		.ifnum = QUIRK_NO_INTERFACE
+	}
+},
#undef USB_DEVICE_VENDOR_SPEC
--
2.17.1

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel


_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel




[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux