On Fri, Nov 23, 2018 at 03:27:29PM +0100, Ladislav Michl wrote:
> Move device enable to probe function. Doing that from prepare
> callback allows only DAC to be enabled.
This seems like it'll be a power consumption regression - instead of
managing the power at runtime we'll just leave the power on all the
time. The normal place to do this would be either directly through DAPM
or via set_bias_level() - the latter seems a better fit here.
> While here move suspend and resume functions to more common place.
It would be better to split this out from the rest of the change as it's
a fairly large bit of code motion relative to the rest of the patch.
> @@ -491,19 +458,40 @@ static int max9867_i2c_probe(struct i2c_client *i2c,
> }
> ret = regmap_read(max9867->regmap, MAX9867_REVISION, ®);
> if (ret < 0) {
> - dev_err(&i2c->dev, "Failed to read: %d\n", ret);
> + dev_err(&i2c->dev, "Failed to read revision: %d\n", ret);
> return ret;
> }
This is a cosmetic change unrelated to the rest of the patch, it should
be sent separately.
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
