On Thu, Nov 22, 2018 at 12:55:09AM +0000, Kuninori Morimoto wrote:
> +void snd_soc_of_parse_node_prefix(struct device_node *np,
> struct snd_soc_codec_conf *codec_conf,
> struct device_node *of_node,
> const char *propname);
> +#define snd_soc_of_parse_audio_prefix(card, conf, node, name) \
> + snd_soc_of_parse_node_prefix((card)->dev->of_node, \
> + (conf), (node), (name))
This is basically fine but it'd be better to make this a static inline
rather than a #define - it helps with error messages and type safety.
I'll apply the series since otherwise this looks good, please send a
followup patch fixing this.
> +
> int snd_soc_of_parse_audio_routing(struct snd_soc_card *card,
> const char *propname);
> unsigned int snd_soc_of_parse_daifmt(struct device_node *np,
> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
> index 6ddcf12..012000d 100644
> --- a/sound/soc/soc-core.c
> +++ b/sound/soc/soc-core.c
> @@ -3484,12 +3484,11 @@ int snd_soc_of_parse_tdm_slot(struct device_node *np,
> }
> EXPORT_SYMBOL_GPL(snd_soc_of_parse_tdm_slot);
>
> -void snd_soc_of_parse_audio_prefix(struct snd_soc_card *card,
> - struct snd_soc_codec_conf *codec_conf,
> - struct device_node *of_node,
> - const char *propname)
> +void snd_soc_of_parse_node_prefix(struct device_node *np,
> + struct snd_soc_codec_conf *codec_conf,
> + struct device_node *of_node,
> + const char *propname)
> {
> - struct device_node *np = card->dev->of_node;
> const char *str;
> int ret;
>
> @@ -3502,7 +3501,7 @@ void snd_soc_of_parse_audio_prefix(struct snd_soc_card *card,
> codec_conf->of_node = of_node;
> codec_conf->name_prefix = str;
> }
> -EXPORT_SYMBOL_GPL(snd_soc_of_parse_audio_prefix);
> +EXPORT_SYMBOL_GPL(snd_soc_of_parse_node_prefix);
>
> int snd_soc_of_parse_audio_routing(struct snd_soc_card *card,
> const char *propname)
> --
> 2.7.4
>
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
