Re: [PATCH 01/35] axfer: add an entry point for this command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 13 Nov 2018 07:41:13 +0100,
Takashi Sakamoto wrote:
> 
> This commit adds a new command, 'axfer' ('ALSA transfer'), to transfer data
> frames described in asound.h. This command is intended to replace current
> aplay. The most of features and command line parameters come from aplay as
> much as possible, while it has more better feature and code to maintain.
> 
> This commit adds an entry point for this command. Current option system of
> aplay is still available, while this command has a sub-command system like
> commands in iproute2.
> 
> Currently, two sub-commands are supported; 'list' and 'transfer'. The
> 'list' sub-command has the same effect as '-l' and '-L' options of aplay.
> The 'transfer' sub-command has the same effect as the main feature of
> aplay. For the sub-command system, an option for stream direction is
> required; '-P' for playback and '-C' for capture. If you create symbolic
> links to this binary for aplay/arecord, please execute:
> $ ln -s axfer aplay
> $ ln -s axfer arecord
> 
> Actual code for each sub-command will be implemented in later commits.
> 
> Signed-off-by: Takashi Sakamoto <o-takashi@xxxxxxxxxxxxx>

Although all patches have been merged, below are a few suggestions:

- Please make help working.  It took some time for me until figuring
  out the fact that the direction option is mandatory, for example.

- The input/output from/to a terminal can be checked via isatty().
  That allows us to see garbages by a mistakenly started command.

- A man page.  (I thought Debian mandates it?)


In anyway, thanks for your hard work!


Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux