Re: [PATCH] ASoC: dapm: Use less aggressive caching to ensure correctness

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 05, 2018 at 07:19:12PM +0800, Tzung-Bi Shih wrote:

> +++ b/sound/soc/soc-dapm.c
> @@ -2722,7 +2722,7 @@ static int snd_soc_dapm_add_path(struct snd_soc_dapm_context *dapm,
>  		dapm_mark_dirty(widgets[dir], "Route added");
>  	}
>  
> -	if (dapm->card->instantiated && path->connect)
> +	if (path->connect)
>  		dapm_path_invalidate(path);
>  
>  	return 0;

The whole point with the instantiated check here is that when we
instantiate the card we're supposed to go through and redo all the DAPM
configuration for the card in one fell swoop rather than having to
constantly redo things while we're building up the graph.  If that
invalidation isn't happening then we should fix that.

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux