Re: [PATCH 04/16] ASoC: cirrus: use devm_snd_soc_register_component()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 07, 2018 at 01:01:05AM +0000, Kuninori Morimoto wrote:

> @@ -422,8 +420,6 @@ static int ep93xx_ac97_remove(struct platform_device *pdev)
>  {
>  	struct ep93xx_ac97_info	*info = platform_get_drvdata(pdev);
>  
> -	snd_soc_unregister_component(&pdev->dev);
> -
>  	/* disable the AC97 controller */
>  	ep93xx_ac97_write_reg(info, AC97GCR, 0);
>  

Similar ordering thing here - it's generally fine to convert to devm_ if
the unregister is the last thing in the remove function but otherwise
you need to be careful.

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux