On 09/03/2018 06:30 AM, Mark Brown wrote: > On Fri, Aug 31, 2018 at 01:17:37PM -0500, Andrew F. Davis wrote: >> The notification handler sets the reset line but never re-enables it >> as no one is listening for an enable event, this is certainly broken >> and was most likely just copied from other CODECs, remove this code. > > Why not fix it? The usual pattern would be to take the CODEC out of > reset when bringing the bias back to standby. > The only time this code gets called outside of the normal power on/off path is regulator_force_disable(). And the enable event is only called inside regulator_enable() which would already be part of the normal power up path. I still don't see the need for this code at all, I do not want to fix unused broken code, and if no one else will fix it, the code should be dropped. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
