Re: [PATCH 3/3] ASoC: cs4265: Add a SPDIF enable actl

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 27/08/18 18:24, Charles Keepax wrote:
On Mon, Aug 27, 2018 at 08:58:44AM +1000, Matt Flax wrote:
This patch adds a SPDIF enable/disable toggle switch to the
sound controls.

Signed-off-by: Matt Flax <flatmax@xxxxxxxxxxx>
---
  sound/soc/codecs/cs4265.c | 8 ++++++++
  1 file changed, 8 insertions(+)

diff --git a/sound/soc/codecs/cs4265.c b/sound/soc/codecs/cs4265.c
index 17d7e6f0..cdfcca9c 100644
--- a/sound/soc/codecs/cs4265.c
+++ b/sound/soc/codecs/cs4265.c
@@ -112,6 +112,13 @@ static const char * const cam_mono_stereo_text[] = {
  static SOC_ENUM_SINGLE_DECL(spdif_mono_stereo_enum, CS4265_SPDIF_CTL2, 2,
  		cam_mono_stereo_text);
+static const char * const spdif_enable_text[] = {
+	"Enabled", "Disabled"
+};
If the values are just on/off would not a SOC_SINGLE be more
appropriate?

OK that sounds like a better idea, I will implement a SOC_SINGLE. Thanks for the guidance.


+
+static SOC_ENUM_SINGLE_DECL(spdif_enable_enum, CS4265_SPDIF_CTL2, 5,
+		spdif_enable_text);
+
  static const char * const mono_select_text[] = {
  	"Channel A", "Channel B"
  };
@@ -151,6 +158,7 @@ static const struct snd_kcontrol_new cs4265_snd_controls[] = {
  				1, 1),
  	SOC_SINGLE("ADC Soft Ramp Switch", CS4265_ADC_CTL2, 7,
  				1, 0),
+	SOC_ENUM("SPDIF Enable", spdif_enable_enum),
Although you would want to then call this something like "SPDIF
Switch".

Yes, sounds good.


  	SOC_SINGLE("E to F Buffer Disable Switch", CS4265_SPDIF_CTL1,
  				6, 1, 0),
  	SOC_ENUM("C Data Access", cam_mode_enum),
--
2.17.1
Thanks,
Charles
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux