Hi,
On Aug 10 2018 23:56, Takashi Iwai wrote:
On Wed, 08 Aug 2018 17:56:29 +0200,
Emmanuel Gil Peyrot wrote:
This doesn’t work yet, we require Gtk 3.0 rather than 2.0 and the API
changed quite a lot.
Signed-off-by: Emmanuel Gil Peyrot <linkmauve@xxxxxxxxxxxx>
Thanks for the patches. Most of changes look good, but also most of
patches have no change log at all. That's already a bad sign.
Could you give some details, especially why the change is needed, in
each patch and resubmit as a patchset? At best, send with a cover
letter and a thread as a patch set at the next time (git-send-email
can manage it well).
In my opinion, the aim of this patchset is porting from Gtk+2.0 to
Gtk+3.0, according to EOL of python bindings. Original script uses
PyGtk[1], which is an application of Gtk+2.0, but PyGtk is already at
the end of life and usage of PyGObject[2] to access to metadata of
Gtk+3.0 is a fresh way instead. In this point, Emmanuel's proposal is
preferable in 2018.
Anyway, I encourage Emmanuel to re-post this patchset with enough
comment according to maintainer's advice. I'll review his next post for
merging.
[1] https://github.com/GNOME/pygtk
[2] https://gitlab.gnome.org/GNOME/pygobject
Thanks
Takashi Sakamoto
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
