Re: [PATCH - hwmixvolume 1/9] hwmixvolume: replace PyGTK with gobject-introspection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Aug 10 2018 23:56, Takashi Iwai wrote:
On Wed, 08 Aug 2018 17:56:29 +0200,
Emmanuel Gil Peyrot wrote:

This doesn’t work yet, we require Gtk 3.0 rather than 2.0 and the API
changed quite a lot.

Signed-off-by: Emmanuel Gil Peyrot <linkmauve@xxxxxxxxxxxx>

Thanks for the patches.  Most of changes look good, but also most of
patches have no change log at all.  That's already a bad sign.

Could you give some details, especially why the change is needed, in
each patch and resubmit as a patchset?  At best, send with a cover
letter and a thread as a patch set at the next time (git-send-email
can manage it well).

I'm familiar with g-i. If you need reviewers, please add me to CC list in next time you post, freely.


Regards

Takashi Sakamoto
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel




[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux