On 08/10/2018 01:37 PM, Robert Rosengren wrote:
>
> On 08/10/2018 12:55 PM, Mark Brown wrote:
>> On Fri, Aug 10, 2018 at 08:07:56AM +0200, Robert Rosengren wrote:
>>
>>> +bool adau17x1_has_safeload(struct adau *adau)
>>> +{
>>> + switch (adau->type) {
>>> + case ADAU1761:
>>> + case ADAU1781:
>>> + return true;
>>> + default:
>>> + return false;
>>> + }
>>> +}
>>> +EXPORT_SYMBOL_GPL(adau17x1_has_safeload);
>>
>> Why is this exported - what are the intended users?
>>
>
> Just followed pattern for adau17x1_has_dsp and adau17x1_setup_firmware, but can't find any code using those methods either. So maybe go for static function, and provide another patch making existing two functions also static and not exported?
I believe those might have been used in either adau1761.c or adau1781.c at
some point. But if they are not used any longer they should be made static
and none exported.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
