Re: [PATCH v2 01/10] ASoC: dt-bindings: add dt bindings for wcd9335 audio codec

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks for the review.

On 31/07/18 21:43, Rob Herring wrote:
+
+- reset-gpio:
reset-gpios

Yep, reset-gpios makes more inline with others!
+	Usage: required
+	Value type: <String Array>
+	Definition: Reset gpio line
+
+- qcom,ifd:
+	Usage: required
+	Value type: <phandle>
+	Definition: SLIM interface device
Wouldn't this be the parent?

No, Interface device is just like other slim device and is part of SLIMbus Component and has a unique address. Every SLIMbus component has one interface device.
...
+
+codec@1{
audio-codec@1

Yep, I will fix this in next version.

+	compatible = "slim217,1a0";
+	reg  = <1 0>;

Thanks,
srini
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux