On Mon, Jul 30, 2018 at 09:49:08AM +0100, Mark Brown wrote: > On Fri, Jul 27, 2018 at 01:59:29PM +0100, Jorge Sanjuan wrote: > > From: Edward Cragg <edward.cragg@xxxxxxxxxxxxxxx> > > > > Add a callback to configure TDM settings for the Tegra30 > > I2S ASoC 'platform' driver. > > > > Signed-off-by: Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx> > > Signed-off-by: Edward Cragg <edward.cragg@xxxxxxxxxxxxxxx> > > This says it was britten by Edward but there's a signoff from Ben before > his? Editing accdient, I was originally going to submit this series. > > + dev_dbg(dai->dev, "%s: setting TDM: tx_mask: 0x%08x rx_mask: 0x%08x" > > + "slots: 0x%08x width: %d\n", > > + __func__, tx_mask, rx_mask, slots, slot_width); > > Please don't split log messages over lines, it makes it harder to grep > for them. Just use a long line. > > I'm also not seeing any validation of the parameters? > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@xxxxxxxxxxxxxxxx > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel -- Ben Dooks, ben@xxxxxxxxx, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
