Re: [PATCH] ASoC: topology: Increase SND_SOC_TPLG_NUM_TEXTS to 32

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/20/18 7:38 AM, Mark Brown wrote:
On Fri, Jul 20, 2018 at 03:57:06PM +0530, Puneeth Prabhu wrote:

  /* string sizes */
-#define SND_SOC_TPLG_NUM_TEXTS		16
+#define SND_SOC_TPLG_NUM_TEXTS		32

This will increase the size of the texts and values fields of at least
snd_soc_tplg_enum_control which on the face of it appears to be an
incompatible ABI change, topology files created with the old value will
have a different layout for these structures to those created with the
new one.

Agree with Mark on both points (de-duplication needed and backwards compatibility). If we are going to respin a new version, there are a couple of known limitations we may want to fix as well, such as the limitation to 8 channels and others I will remember once I've had more coffee.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux