Re: [PATCH 0/3] sound/usb/line6: fix some styling issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 18 Jun 2018 12:29:36 +0200,
Roman Sommer wrote:
> 
> CC: Jaroslav Kysela <perex@xxxxxxxx>
> CC: Takashi Iwai <tiwai@xxxxxxxx>
> CC: Takashi Sakamoto <o-takashi@xxxxxxxxxxxxx>
> CC: "Hans P. Möller Ebner" <hmoller@xxxxx>
> CC: Kees Cook <keescook@xxxxxxxxxxxx>
> CC: Kate Stewart <kstewart@xxxxxxxxxxxxxxxxxxx>
> CC: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> CC: "Fabián Inostroza" <soulsonceonfire@xxxxxxxxx>
> CC: Bhumika Goyal <bhumirks@xxxxxxxxx>
> CC: Philippe Ombredanne <pombredanne@xxxxxxxx>
> CC: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> CC: alsa-devel@xxxxxxxxxxxxxxxx
> CC: linux-kernel@xxxxxxxxxxxxxxx
> 
> 
> This patchseries addresses some styling issues in sound/usb/line6 found by
> checkpatch.

Are you working further on this driver to fix any real bugs (or
implements something new), or it's an action "just because checkpatch
tells"?  I'd take such cleanup patches only for the former case.


thanks,

Takashi


> 
> Roman Sommer (3):
>   sound/line6: checkpatch: fix block comment style
>   sound/line6: unsigned -> unsigned int
>   sound/line6: add newline after declarations
> 
>  sound/usb/line6/capture.c  |  20 ++++-----
>  sound/usb/line6/driver.c   | 110 ++++++++++++++++++++++-----------------------
>  sound/usb/line6/driver.h   |  33 +++++++-------
>  sound/usb/line6/midi.c     |  24 +++++-----
>  sound/usb/line6/midibuf.c  |   6 +--
>  sound/usb/line6/pcm.c      |  26 +++++------
>  sound/usb/line6/pcm.h      |  74 +++++++++++++++---------------
>  sound/usb/line6/playback.c |  36 ++++++++-------
>  sound/usb/line6/pod.c      |  60 ++++++++++++-------------
>  sound/usb/line6/podhd.c    |   8 ++--
>  sound/usb/line6/toneport.c |  30 ++++++-------
>  sound/usb/line6/variax.c   |  40 ++++++++---------
>  12 files changed, 235 insertions(+), 232 deletions(-)
> 
> -- 
> 2.7.4
> 
> 
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel




[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux