Hi, I'll fix this in v2. Thanks for your kind reply. Best, Zhouyang 2018-06-11 21:26 GMT+08:00 Takashi Iwai <tiwai@xxxxxxx>: > On Mon, 11 Jun 2018 10:08:40 +0200, > Zhouyang Jia wrote: > > > > When snd_ctl_add fails, the lack of error-handling code may > > cause unexpected results. > > > > This patch adds error-handling code after calling snd_ctl_add. > > > > Signed-off-by: Zhouyang Jia <jiazhouyang09@xxxxxxxxx> > > I postpone this one because the change won't give anything as is > although this change itself is correct. If you look at the code > closely, the caller of snd_sonicvibes_create_gameport() ignores the > return value. > So we need to fix two places. > > > thanks, > > Takashi > _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
