On 5/30/18 7:22 AM, Takashi Iwai wrote:
On Wed, 30 May 2018 14:12:00 +0200,
Pierre-Louis Bossart wrote:
On 5/29/18 10:16 PM, Vinod wrote:
On 29-05-18, 18:30, Pierre-Louis Bossart wrote:
All conditionally-defined routines in include/sound/soc.h expose a
static inline fallback to avoid 0-day warnings and compilation issues,
except snd_soc_new_compress().
Hey Pierre,
Thanks for the fix, but typically the title should not mention things like
reporter. It should describe the change, so something like "Add
snd_soc_new_compress() wrapper when CONFIG_SND_SOC_COMPRESS is not defined"
Right now patch title is not describing the change
I follow the guidelines in [1] of describing the problem statement,
provide details and then how the problem is addressed in the message.
It's not clear to me that you need to describe the solution in the title.
[1] https://www.kernel.org/doc/html/v4.16/process/submitting-patches.html
Well, a good patch describes itself concisely but clearly in the
subject line in general. And, in this regard, whether it's reported
by 0-day bot or not is pretty much useless. We'd merge a fix not
because 0-day bot complains; instead, we merge it because it addresses
some real bug. In this particular case, a build error with
CONFIG_SND_SOC_COMPRESS=n. So this should have been mentioned in the
subject line.
Got it, thanks!
Takashi
Fixes: 5db6aab6f36f ('ASoC: topology: Add support for compressed PCMs')
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
---
include/sound/soc.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/include/sound/soc.h b/include/sound/soc.h
index 600a7ebd10c0..1378dcd2128a 100644
--- a/include/sound/soc.h
+++ b/include/sound/soc.h
@@ -462,6 +462,11 @@ struct snd_soc_component *snd_soc_lookup_component(struct device *dev,
int soc_new_pcm(struct snd_soc_pcm_runtime *rtd, int num);
#ifdef CONFIG_SND_SOC_COMPRESS
int snd_soc_new_compress(struct snd_soc_pcm_runtime *rtd, int num);
+#else
+static inline int snd_soc_new_compress(struct snd_soc_pcm_runtime *rtd, int num)
+{
+ return 0;
+}
#endif
void snd_soc_disconnect_sync(struct device *dev);
--
2.14.1
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
