On 23 May 2018 07:14, Mac Chiang wrote:
> From: Mac Chiang <mac.chiang@xxxxxxxxx>
>
> unexpected error: PLL input clock 0 below valid range
>
> backport from broonie's tree
> commit fd0f237572ad
> ("ASoC: Intel: bxt: Move codec sysclk config to codec_init function")
>
> The MCLK for DA7219 does not change in this platform, but is
> currently being configured everytime as part of the platform_clock
> event handler for DAPM. The upshot of this is that we have
> unnecessary calls to this function, and it also means that if
> a stream hasn't yet been started, DA7219 driver does not have the
> correct MCLK rates programmed and so the HP detection feature does
> not operate as expected.
>
> This patch rectifies this issue by moving the sysclk call to
> codec_init function so it's only called once at initialisation.
>
> Signed-off-by: Adam Thomson <Adam.Thomson.Opensource@xxxxxxxxxxx>
> Acked-by: Sathyanarayana Nujella <sathyanarayana.nujella@xxxxxxxxx>
> Singed-off-by: Mac Chiang <mac.chiang@xxxxxxxxx>
> ---
> sound/soc/intel/boards/kbl_da7219_max98357a.c | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/sound/soc/intel/boards/kbl_da7219_max98357a.c
> b/sound/soc/intel/boards/kbl_da7219_max98357a.c
> index 60e739f..88fbc6a 100644
> --- a/sound/soc/intel/boards/kbl_da7219_max98357a.c
> +++ b/sound/soc/intel/boards/kbl_da7219_max98357a.c
> @@ -65,14 +65,6 @@ static int platform_clock_control(struct
> snd_soc_dapm_widget *w,
> return -EIO;
> }
>
> - /* Configure sysclk for codec */
> - ret = snd_soc_dai_set_sysclk(codec_dai, DA7219_CLKSRC_MCLK, 24576000,
> - SND_SOC_CLOCK_IN);
Code here is setting the MCLK rate for the codec as being 24.576MHz but...
> - if (ret) {
> - dev_err(card->dev, "can't set codec sysclk configuration\n");
> - return ret;
> - }
> -
> if (SND_SOC_DAPM_EVENT_OFF(event)) {
> ret = snd_soc_dai_set_pll(codec_dai, 0,
> DA7219_SYSCLK_MCLK, 0, 0);
> @@ -169,9 +161,18 @@ static int kabylake_da7219_codec_init(struct
> snd_soc_pcm_runtime *rtd)
> {
> struct kbl_codec_private *ctx = snd_soc_card_get_drvdata(rtd->card);
> struct snd_soc_component *component = rtd->codec_dai->component;
> + struct snd_soc_dai *codec_dai = rtd->codec_dai;
> struct snd_soc_jack *jack;
> int ret;
>
> + /* Configure sysclk for codec */
> + ret = snd_soc_dai_set_sysclk(codec_dai, DA7219_CLKSRC_MCLK, 19200000,
> + SND_SOC_CLOCK_IN);
...here you're setting MCLK rate to be 19.2MHz. Is that correct?
> + if (ret) {
> + dev_err(rtd->dev, "can't set codec sysclk configuration\n");
> + return ret;
> + }
> +
> /*
> * Headset buttons map to the google Reference headset.
> * These can be configured by userspace.
> --
> 2.7.4
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@xxxxxxxxxxxxxxxx
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
