On Mon, May 21, 2018 at 2:58 PM, Yisheng Xie <xieyisheng1@xxxxxxxxxx> wrote: > match_string() returns the index of an array for a matching string, > which can be used intead of open coded variant. > static int max98088_get_channel(struct snd_soc_component *component, const char *name) > { > + int ret = match_string(eq_mode_name, ARRAY_SIZE(eq_mode_name), name); I would rather split this and move an assignment to the line before 'if' > > /* Shouldn't happen */ > + if (ret < 0) > + dev_err(component->dev, "Bad EQ channel name '%s'\n", name); > return -EINVAL; return ret; ? > } > > -- > 1.7.12.4 > -- With Best Regards, Andy Shevchenko _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel