Re: [PATCH v3] ASoC: ssm2305: Add amplifier driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 18, 2018 at 10:07:11AM +0200, Marco Felsch wrote:
> On 18-05-17 18:08, Mark Brown wrote:

> > 
> > Please submit a followup patch which makes the entire comment a C++ one
> > rather than mixing them in the same comment block, it makes things look
> > more intentional.

> I'm a bit confused. As documented by the 
> Documentation/process/license-rules.rst the license header should be a C++
> comment but for all block comments the 'normal' coding style should be
> applied. I can seperate the license header and the comment to make it
> more intentional.

> // SPDX-License-Identifier: GPL-2.0
> 
> /*
>  * Analog Devices SSM2305 Amplifier Driver
>  *
>  * Copyright (C) 2018 Pengutronix, Marco Felsch <kernel@xxxxxxxxxxxxxx>
>  */

> Is that better?

No, that still looks like a mess.  Just make the whole thing a C++
comment.

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux