Hi Geert, Em Tue, 17 Apr 2018 19:49:12 +0200 Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> escreveu: > Remove dependencies on HAS_DMA where a Kconfig symbol depends on another > symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST". Applying a patch like that is hard, as there are lots of churn at the code. That's against latest media upstream: checking file drivers/media/pci/intel/ipu3/Kconfig Hunk #1 FAILED at 4. 1 out of 1 hunk FAILED checking file drivers/media/pci/solo6x10/Kconfig checking file drivers/media/pci/sta2x11/Kconfig Hunk #1 FAILED at 1. 1 out of 1 hunk FAILED checking file drivers/media/pci/tw5864/Kconfig checking file drivers/media/pci/tw686x/Kconfig checking file drivers/media/platform/Kconfig Hunk #2 FAILED at 63. Hunk #3 succeeded at 81 (offset 1 line). Hunk #4 succeeded at 91 (offset 1 line). Hunk #5 succeeded at 101 (offset 1 line). Hunk #6 succeeded at 111 (offset 1 line). Hunk #7 succeeded at 124 (offset 1 line). Hunk #8 succeeded at 142 (offset 1 line). Hunk #9 succeeded at 169 (offset 1 line). Hunk #10 succeeded at 186 (offset 1 line). Hunk #11 succeeded at 197 (offset 1 line). Hunk #12 succeeded at 213 (offset 1 line). Hunk #13 succeeded at 227 (offset 1 line). Hunk #14 succeeded at 254 (offset 1 line). Hunk #15 succeeded at 265 (offset 1 line). Hunk #16 succeeded at 275 (offset 1 line). Hunk #17 succeeded at 284 (offset 1 line). Hunk #18 succeeded at 295 (offset 1 line). Hunk #19 succeeded at 303 (offset 1 line). Hunk #20 succeeded at 312 (offset 1 line). Hunk #21 succeeded at 338 (offset 1 line). Hunk #22 succeeded at 383 (offset 1 line). Hunk #23 succeeded at 397 (offset 1 line). Hunk #24 succeeded at 422 (offset 1 line). Hunk #25 succeeded at 435 (offset 1 line). Hunk #26 succeeded at 452 (offset 1 line). Hunk #27 succeeded at 470 (offset 1 line). Hunk #28 succeeded at 612 (offset 1 line). 1 out of 28 hunks FAILED > In most cases this other symbol is an architecture or platform specific > symbol, or PCI. > > Generic symbols and drivers without platform dependencies keep their > dependencies on HAS_DMA, to prevent compiling subsystems or drivers that > cannot work anyway. Actually, depends on HAS_DMA was introduced on media because builds were failing otherwise. We started adding it before the addition of COMPILE_TEST. Can we just remove all HAS_DMA Kconfig dependencies as a hole from the entire media subsystem, with something like: $ for i in $(find drivers/media -name Kconfig) $(find drivers/staging/media -name Kconfig); do sed '/depends on HAS_DMA/d;s/ && HAS_DMA//g' -i $i; done Or would it cause build issues? Regards, Mauro Thanks, Mauro _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
